Fix that CI checks are not running in merge queue#62
Merged
Conversation
nhorton
changed the title
GitHub has a known bug where PRs that are up-to-date with the target branch may trigger fast-forward merges. When this happens, GitHub looks for check statuses on the PR commit instead of triggering merge_group workflows. Previously, claude-code-test.yml had different job names for PR vs merge_group events: - pr-check: ran on pull_request - validate-generation: ran only on merge_group - claude-code-e2e: ran only on merge_group When GitHub's fast-forward optimization kicked in, it couldn't find validate-generation or claude-code-e2e checks on the PR commit because those jobs never ran for PRs. Fix: Make validate-generation and claude-code-e2e run on BOTH events, with step-level conditions to skip actual work on PRs. This ensures the check names exist for PRs, working around GitHub's merge queue bug. See: https://github.com/orgs/community/discussions/151100
Simplify merge_group triggers by removing the explicit types filter. Since checks_requested is the only activity type for merge_group, omitting it should have the same effect. This eliminates a potential source of issues with the event not being recognized.
nhorton
force-pushed
the
claude/debug-merge-queue-ci-phpV5
branch
from
bef2f54 to
51183ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI checks that run in the PR don't run when it goes to the merge queue.